[#73356] show relation page links in the wiki tab#22737
Open
Kharonus wants to merge 3 commits intofeature/72971-show-inline-wiki-page-linksfrom
Open
[#73356] show relation page links in the wiki tab#22737Kharonus wants to merge 3 commits intofeature/72971-show-inline-wiki-page-linksfrom
Kharonus wants to merge 3 commits intofeature/72971-show-inline-wiki-page-linksfrom
Conversation
|
Caution The provided work package version does not match the core version Details:
Please make sure that:
|
- https://community.openproject.org/work_packages/73356 - add new link group for relation page links - add button for adding links - still disabled - add action menu for link removal - no functionality
Kharonus
force-pushed
the
implementation/73356-show-existing-relation-wiki-page-links
branch
from
13cad6e to
fc6975e
Compare
…ntation/73356-show-existing-relation-wiki-page-links
| container.with_row do | ||
| render(Primer::Beta::Blankslate.new(border: false)) do |empty_placeholder| | ||
| empty_placeholder.with_heading(tag: :h2).with_content(t(".empty_heading")) | ||
| empty_placeholder.with_description { t(".empty_text") } |
Contributor
There was a problem hiding this comment.
Same as in the previous PR: Let's rename empty_placeholder to blankslate for brevity and clarity.
| belongs_to :linkable, polymorphic: true | ||
|
|
||
| def relation? | ||
| is_a?(RelationPageLink) |
Contributor
There was a problem hiding this comment.
What do you think about implementing these by choice, not by subclass? The behaviour would be the same, just the way we implement it would be different:
# page_link.rb
def relation? = false
def inline? = false
# relation_page_link.rb
def relation? = true
# inline_page_link.rb
def inline? = trueThis would mean that:
- the superclass doesn't need to have knowledge about the subclasses implementing it
- it's clearer when looking at a subclass why it responds to certain methods
Member
Author
There was a problem hiding this comment.
yeah, I think that's fine!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket
#73356
What are you trying to accomplish?
What approach did you choose and why?