Conversation
- https://community.openproject.org/work_packages/72971 - added provider link group - added inline wiki page links with empty state - add a counter to notification center tabs - show fake wiki page titles
|
Caution The provided work package version does not match the core version Details:
Please make sure that:
|
- add lefthook to the npm dev dependencies - this allows executing lefthook even when gems are not installed on the host machine - e.g. important for docker development
| "devDependencies": { | ||
| "@redocly/cli": "^2.17.0" | ||
| "@redocly/cli": "^2.17.0", | ||
| "lefthook": "^2.1.5" |
There was a problem hiding this comment.
this allows executing lefthook, if bundler is not installed on host machine and the lefthook gem is not available.
this is the case e.g. in the docker dev environment, where the gems are only installed in a docker volume.
There was a problem hiding this comment.
this looks very unrelated to the rest of the PR.
Do I understand it correctly, that this means we'll install lefthook via two sources? Once via bundler and once via NPM?
There was a problem hiding this comment.
hmm, yes, but the node modules are only installed if triggered manually.
Maybe we can solve this differently, but I have no lefthook running on the host machine, as i have no bundler running. and I was not able to get the lefthook to work without installing it outside of bundler.
There was a problem hiding this comment.
I see.
To be honest: I am not using lefthook at all, so I don't care too much. But the change and its implications feel out-of-place for this PR. For example you could now easily install two different versions (one via bundler, one via NPM) and fail to update properly (only one of two).
There was a problem hiding this comment.
In the end, this shouldn't clash to hard, I think. When running lefthook - either on host or inside a docker container - it will take whatever executable is on a higher position in the $PATH, right?
There was a problem hiding this comment.
Yeah exactly. Which means it may or may not be the one that you expect. E.g. now that everyone is used to get it via bundler, they might be confused if their NPM path position is higher and they get a different version then expected.
Same it thinkable vice-versa.
One specific example: Lefthook 9000 adds a cool new feature and someone updates our Gemfile to that version. Then people are confused why it doesn't work.
NobodysNightmare
left a comment
NobodysNightmare
left a comment
There was a problem hiding this comment.
I'll still have to look at the change from a UI side, but my biggest concern is how we want to render the aggregate number of page links, when that number might not be known to OpenProject from a simple database query.
modules/wikis/app/components/wikis/inline_page_links_component.html.erb
Outdated
Show resolved
Hide resolved
modules/wikis/app/components/wikis/work_package_wikis_tab_component.html.erb
Show resolved
Hide resolved
- emphasize, that counting logic is still incomplete - move wiki locales to module - minor variable renaming
2 participants
Ticket
#72971
What are you trying to accomplish?
What approach did you choose and why?