Skip to content

T8218: Updated workflows for pullrequest_target policy change#92

Merged
dmbaturin merged 1 commit intovyos:currentfrom
kumvijaya:current
Apr 9, 2026
Merged

T8218: Updated workflows for pullrequest_target policy change#92
dmbaturin merged 1 commit intovyos:currentfrom
kumvijaya:current

Conversation

@kumvijaya
Copy link
Copy Markdown
Contributor

Proposed Commit Message

This PR updates pull_request_target workflows to comply with GitHub's recent policy change announced on November 7, 2025 Actions: pull_request_target and environment branch protections changes.

Background
GitHub updated how pull_request_target workflows are evaluated. Previously, these workflows were evaluated using the PR's target branch. Now, they are always evaluated using the repository's default branch (current). This means branch-filtered workflows will only trigger reliably if they exist and match on the default branch.

Changes
Updated the workflows to include all supported branches in their pull_request_target trigger:

Since pull_request_target workflows are now evaluated from the default branch, the workflow file must exist unchanged on the default branch. To support branch-specific triggering across all maintained branches (current, circinus, sagitta), the branch filters must explicitly list all branches or be removed entirely.

These changes ensure that:
Workflows trigger correctly for PRs targeting any of the three supported branches
The workflow files are evaluated from the current branch as per GitHub's new requirement

Note:
As these workflows doesn't have any branch-specific logic, no changes needed apart from this.

summary: no more than 70 characters

A description of what the change being made is and why it is being
made, if the summary line is insufficient.  The blank line above is
required. This should be wrapped at 72 characters, but otherwise has
no particular length requirements.

If you need to write multiple paragraphs, feel free.

LP: #NNNNNNN (replace with the appropriate bug reference or remove
this line entirely if there is no associated bug)

Additional Context

Test Steps

Checklist:

  • My code follows the process laid out in the documentation
  • I have updated or added any unit tests accordingly
  • I have updated or added any documentation accordingly

Copy link
Copy Markdown

@asklymenko asklymenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Modify workflow to use new "pullrequest_target" policy.

Copy link
Copy Markdown
Member

@dmbaturin dmbaturin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see obvious issues and I trust @asklymenko's judgement.

@dmbaturin dmbaturin merged commit 12ffaa9 into vyos:current Apr 9, 2026
1 of 2 checks passed
@vyosbot vyosbot added mirror-initiated This PR initiated for mirror sync workflow mirror-completed This PR has been mirrored successfully and removed mirror-initiated This PR initiated for mirror sync workflow labels Apr 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bp/circinus bp/sagitta mirror-completed This PR has been mirrored successfully

Development

Successfully merging this pull request may close these issues.

4 participants