fix: smarter fallback team selection for scope inference#120
Open
fix: smarter fallback team selection for scope inference#120
Conversation
… is part of as a fallback
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Instead of always falling back to the username, prefer the user's configured default team (defaultTeamId). Falls back to username when defaultTeamId is not set. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
gr2m
commented
Mar 28, 2026
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
marc-vercel
approved these changes
Apr 8, 2026
Collaborator
marc-vercel
left a comment
There was a problem hiding this comment.
Overall LGTM, left 3 comments (two of them are optional).
I see that the tests mock the API response, but given that we are changing API requests/responses, have we manually tested all the flows? If possible I would love to have some integration tests, but because we are dealing with auth I do not think it will be easy.
QuiiBz
reviewed
Apr 10, 2026
QuiiBz
reviewed
Apr 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/v2/userand/v2/teamsin parallel to build an ordered list of candidate teams for scope inferenceuser.defaultTeamIdfirst, then falls back to the best hobby-plan OWNER team (personal team matching username, or most recently updated)billing.plan === 'hobby'andmembership.role === 'OWNER'to avoid selecting pro/enterprise teams