Add extended graph and dummy auto-layout #59#77
Open
handreyrc wants to merge 1 commit intoserverlessworkflow:mainfrom
Open
Add extended graph and dummy auto-layout #59#77handreyrc wants to merge 1 commit intoserverlessworkflow:mainfrom
handreyrc wants to merge 1 commit intoserverlessworkflow:mainfrom
Conversation
handreyrc
changed the title
Contributor
There was a problem hiding this comment.
Pull request overview
Adds SDK graph generation support to the diagram editor core by introducing extended graph types (node size/position, edge types/waypoints), exposing a buildGraph wrapper, and providing a dummy auto-layout implementation with accompanying tests/snapshots.
Changes:
- Added extended graph type definitions and edge-type enrichment (
solveEdgeTypes). - Exposed
buildGraphvia the core SDK wrapper and re-exported core modules. - Added a dummy
applyAutoLayoutimplementation plus integration/unit tests and snapshots.
Reviewed changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 9 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/serverless-workflow-diagram-editor/tests/fixtures/workflows.ts | Added new JSON/YAML workflow fixtures used by graph + auto-layout tests. |
| packages/serverless-workflow-diagram-editor/tests/core/workflowSdk.integration.test.ts | Added integration coverage for buildGraph and extended graph typing/snapshot. |
| packages/serverless-workflow-diagram-editor/tests/core/graph.test.ts | New unit tests for edge type enrichment across default/error/condition/nested cases. |
| packages/serverless-workflow-diagram-editor/tests/core/autoLayout.integration.test.ts | New integration test verifying dummy auto-layout positions/sizes and snapshot. |
| packages/serverless-workflow-diagram-editor/tests/core/snapshots/workflowSdk.integration.test.ts.snap | Snapshot for buildGraph result. |
| packages/serverless-workflow-diagram-editor/tests/core/snapshots/autoLayout.integration.test.ts.snap | Snapshot for applyAutoLayout result. |
| packages/serverless-workflow-diagram-editor/src/core/workflowSdk.ts | Switched to SDK namespace import; added buildGraph wrapper returning extended graph. |
| packages/serverless-workflow-diagram-editor/src/core/index.ts | Re-exported graph and autoLayout modules. |
| packages/serverless-workflow-diagram-editor/src/core/graph.ts | Added extended graph types and solveEdgeTypes. |
| packages/serverless-workflow-diagram-editor/src/core/autoLayout.ts | Added dummy applyAutoLayout implementation to set size/position. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
lornakelly
reviewed
Apr 14, 2026
Contributor
lornakelly
left a comment
lornakelly
left a comment
There was a problem hiding this comment.
Thanks for PR Handrey, nice work. Just a few comments
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 11 out of 11 changed files in this pull request and generated 4 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 11 out of 11 changed files in this pull request and generated 3 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
kumaradityaraj
approved these changes
Apr 15, 2026
Signed-off-by: handreyrc <handrey.cunha@gmail.com>
Contributor
Author
|
Could you review this PR, please? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #59
Summary
This PR adds dummy auto-layout and extended graph types.
Changes