Skip to content

Fix ATen/Config.h missing on Android after arvr_mode constraint migration#18907

Open
mvsfb wants to merge 1 commit intopytorch:mainfrom
mvsfb:export-D100832205
Open

Fix ATen/Config.h missing on Android after arvr_mode constraint migration#18907
mvsfb wants to merge 1 commit intopytorch:mainfrom
mvsfb:export-D100832205

Conversation

@mvsfb
Copy link
Copy Markdown

@mvsfb mvsfb commented Apr 15, 2026

Summary:
Recently D99903392 broke our builds (see multisect on that diff), this is an attempt to fix this.

D99903392 converted arvr_mode from a constraint_setting to a
constraint() rule. This changed how the select() in
aten_headers_for_executorch resolves: Android platforms now match
arvr_mode[enabled], routing to ovrsource_aten_Config.h. But that
target is an oxx_static_library that produces no outputs on Android

Fix: use a nested select to fall back to generated_aten_config_header
on Android, while preserving the OVR variant for non-Android ARVR
platforms. Same pattern as D100438873 but for Android.

Differential Revision: D100832205

…tion

Summary:
Recently D99903392 broke our builds (see multisect on that diff), this is an attempt to fix this.

D99903392 converted arvr_mode from a constraint_setting to a
constraint() rule. This changed how the select() in
aten_headers_for_executorch resolves: Android platforms now match
arvr_mode[enabled], routing to ovrsource_aten_Config.h. But that
target is an oxx_static_library that produces no outputs on Android

Fix: use a nested select to fall back to generated_aten_config_header
on Android, while preserving the OVR variant for non-Android ARVR
platforms. Same pattern as D100438873 but for Android.

Differential Revision: D100832205
@pytorch-bot
Copy link
Copy Markdown

pytorch-bot bot commented Apr 15, 2026

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/18907

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure, 4 Unrelated Failures

As of commit cb77510 with merge base eaef2ed (image):

NEW FAILURE - The following job has failed:

FLAKY - The following jobs failed but were likely due to flakiness present on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Apr 15, 2026
@meta-codesync
Copy link
Copy Markdown
Contributor

meta-codesync bot commented Apr 15, 2026

@mvsfb has exported this pull request. If you are a Meta employee, you can view the originating Diff in D100832205.

@github-actions
Copy link
Copy Markdown

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported meta-exported

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants