Fix ATen/Config.h missing on Android after arvr_mode constraint migration#18907
Fix ATen/Config.h missing on Android after arvr_mode constraint migration#18907mvsfb wants to merge 1 commit intopytorch:mainfrom
Conversation
…tion Summary: Recently D99903392 broke our builds (see multisect on that diff), this is an attempt to fix this. D99903392 converted arvr_mode from a constraint_setting to a constraint() rule. This changed how the select() in aten_headers_for_executorch resolves: Android platforms now match arvr_mode[enabled], routing to ovrsource_aten_Config.h. But that target is an oxx_static_library that produces no outputs on Android Fix: use a nested select to fall back to generated_aten_config_header on Android, while preserving the OVR variant for non-Android ARVR platforms. Same pattern as D100438873 but for Android. Differential Revision: D100832205
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/18907
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New Failure, 4 Unrelated FailuresAs of commit cb77510 with merge base eaef2ed ( NEW FAILURE - The following job has failed:
FLAKY - The following jobs failed but were likely due to flakiness present on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
@mvsfb has exported this pull request. If you are a Meta employee, you can view the originating Diff in D100832205. |
This PR needs a
|
Summary:
Recently D99903392 broke our builds (see multisect on that diff), this is an attempt to fix this.
D99903392 converted arvr_mode from a constraint_setting to a
constraint() rule. This changed how the select() in
aten_headers_for_executorch resolves: Android platforms now match
arvr_mode[enabled], routing to ovrsource_aten_Config.h. But that
target is an oxx_static_library that produces no outputs on Android
Fix: use a nested select to fall back to generated_aten_config_header
on Android, while preserving the OVR variant for non-Android ARVR
platforms. Same pattern as D100438873 but for Android.
Differential Revision: D100832205