Conversation
fd3ea6c to
7c64cc2
Compare
7c64cc2 to
1c19495
Compare
savannahostrowski
left a comment
There was a problem hiding this comment.
Given the numbers we've seen, we should update 0.5-2%...if we're rounding up?
markshannon
left a comment
There was a problem hiding this comment.
Very compelling.
I'd added a few quick comments on the first part of the PEP.
This is long, and might be a bit much to expect anyone to read through in one go.
Maybe some of the supporting analyses could be moved into appendices and linked to from the body of the PEP?
For example, the detailed, but long, analyses of perf and ebpf tools could be moved to appendices.
Co-authored-by: Mark Shannon <Mark.Shannon@arm.com> Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
|
Thanks for the thorough review Mark! Addressed all the inline comments (cross-references to data, clarified the Gregg quote, softened language, added Windows mention, etc). Re: length and moving content to appendices, that is a fair point. I will move the eBPF and perf investigation to the appendix. |
Basic requirements (all PEP Types)
pep-NNNN.rst), PR title (PEP 123: <Title of PEP>) andPEPheaderAuthororSponsor, and formally confirmed their approvalAuthor,Status(Draft),TypeandCreatedheaders filled out correctlyPEP-Delegate,Topic,RequiresandReplacesheaders completed if appropriate.github/CODEOWNERSfor the PEPStandards Track requirements
Python-Versionset to valid (pre-beta) future Python version, if relevantDiscussions-ToandPost-History📚 Documentation preview 📚: https://pep-previews--4896.org.readthedocs.build/pep-0831/