Add missing stacklevel to all warnings.warn() calls#7355
Closed
Add missing stacklevel to all warnings.warn() calls#7355
Conversation
All 9 warnings.warn() calls across the codebase were missing stacklevel, causing warning messages to point to internal lines inside Requests rather than the caller's code. Files fixed: - auth.py: 2 calls (DeprecationWarning for non-string username/password) - __init__.py: 3 calls (RequestsDependencyWarning for missing/old deps) - utils.py: 3 calls (FileModeWarning, DeprecationWarning for deprecated fns) - adapters.py: 1 call (DeprecationWarning for get_connection)
This comment was marked as spam.
This comment was marked as spam.
Author
|
Thanks for the review @afurm!
Yes — the existing warning tests only assert on warning count and category (e.g.
I audited each one:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
All 9
warnings.warn()calls in the codebase are missingstacklevel, causing warning messages to point to internal lines inside Requests rather than the caller's code.Example
Before (without stacklevel):
After (with stacklevel=2):
Changes
auth.pyDeprecationWarningfor non-string username/password__init__.pyRequestsDependencyWarningfor missing/old dependenciesutils.pyFileModeWarning,DeprecationWarningfor deprecated functionsadapters.pyDeprecationWarningfor deprecatedget_connectionAll 9 calls now include
stacklevel=2so warnings correctly reference the caller's code.