Fix wrong signature for DateInterval::createFromDateString in 8.3+#5483
Open
sunkan wants to merge 2 commits intophpstan:2.1.xfrom
Open
Fix wrong signature for DateInterval::createFromDateString in 8.3+#5483sunkan wants to merge 2 commits intophpstan:2.1.xfrom
sunkan wants to merge 2 commits intophpstan:2.1.xfrom
Conversation
Member
|
The linked issue is closed. Please first create an issue from one of the templates at https://github.com/phpstan/phpstan/issues/new/choose and provide a failing playground example. |
Author
|
I did use the "Function signature mismatch" And it says |
Contributor
|
Exemple of the issue https://phpstan.org/r/213cc168-576f-49eb-b1e3-f32de3fdf0bd The DateIntervalDynamicReturnTypeExtension need to be updated too |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes phpstan/phpstan#14479
Summary
In php8.3 the signature changed from
to
now it instead throws an DateMalformedStringException
Reference: https://www.php.net/manual/en/dateinterval.createfromdatestring.php
This pr collides with the fix for phpstan/phpstan#8442 but I don't know how to solve that.