Fix datepart argument parsing in date functions#198
Open
aasimkhan30 wants to merge 3 commits intomainfrom
Open
Fix datepart argument parsing in date functions#198aasimkhan30 wants to merge 3 commits intomainfrom
aasimkhan30 wants to merge 3 commits intomainfrom
Conversation
aasimkhan30
requested review from
chlafreniere,
dzsquared,
kburtram,
llali and
ssreerama
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes: #98
Fixes parser behavior for date functions so the first datepart argument (for example, mm in DATEDIFF(mm, ColA, ColB)) is parsed as IdentifierLiteral instead of ColumnReferenceExpression. Includes regression tests for TSql160, TSql170, and TSqlFabricDW.
Code Changes