Fix TypeError in save_meridian for .textproto & .txtpb formats#1282
Open
farok-amo wants to merge 1 commit intogoogle:mainfrom
Open
Fix TypeError in save_meridian for .textproto & .txtpb formats#1282farok-amo wants to merge 1 commit intogoogle:mainfrom
farok-amo wants to merge 1 commit intogoogle:mainfrom
Conversation
When saving to .textproto or .txtpb format, the file is opened in
binary mode ('wb') but text_format.MessageToString() returns a string.
This causes a TypeError: 'a bytes-like object is required, not str'.
Fixed by encoding the string to UTF-8 bytes before writing to the file.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes TypeError when saving Meridian models in textproto format
Problem
When calling
save_meridian()with a.textprotoor.txtpbfile path,the function raises:
TypeError: a bytes-like object is required, not 'str'
This occurs because:
'wb') on line 355text_format.MessageToString()returns a string, not bytesSolution
Encode the string to UTF-8 bytes before writing:
Testing