Skip to content

Make windows presubmit build Dive host tools faster#841

Open
angela28chen wants to merge 1 commit intogoogle:mainfrom
angela28chen:msbuild-presubmit
Open

Make windows presubmit build Dive host tools faster#841
angela28chen wants to merge 1 commit intogoogle:mainfrom
angela28chen:msbuild-presubmit

Conversation

@angela28chen
Copy link
Copy Markdown
Collaborator

@angela28chen angela28chen commented Apr 13, 2026

Changes:

  • Windows presubmit uses msbuild to build host tools rather than initiating the build with cmake
  • Added github action microsoft/setup-msbuild v3, so that msbuild is on the path of the runner
  • Previous presubmit bottleneck was the Windows builds (~20min), now it runs faster thanks to msbuild being able to use multithreading (~16min)
    • This was not possible when build is initiated via cmake because there is difficulty in passing down flags to the VS generator

Copy link
Copy Markdown
Collaborator

@elviscapiaq elviscapiaq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just by curiosity, what is 30375c66a4eea26614e0d39710365f22f8b0af57 suffix?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants