Skip to content

Add changelog to sdist#436

Merged
carltongibson merged 2 commits intodjango:mainfrom
jayvdb:sdist
May 7, 2025
Merged

Add changelog to sdist#436
carltongibson merged 2 commits intodjango:mainfrom
jayvdb:sdist

Conversation

@jayvdb
Copy link
Copy Markdown
Contributor

@jayvdb jayvdb commented Sep 1, 2022

No description provided.

@adamchainz
Copy link
Copy Markdown
Member

I recommend not distributing the tests. 99.99% of installs do not need them. Those who want them are normally redistributors, can who fetch the tarball from the repo. Last year I removed tests from the sdists in all my projects and heard no complaints.

Is redistributing your motivation here @jayvdb ? Have you considered using repo tarballs?

@jayvdb
Copy link
Copy Markdown
Contributor Author

jayvdb commented Sep 1, 2022

https://pypi.org/project/daphne/#files includes wheels, which is what 99% of installs will fetch.
The sdist is for the other 1% need.

Yes, https://build.opensuse.org/package/show/devel:languages:python:django/python-django-cors-headers and https://build.opensuse.org/package/show/devel:languages:python:django/python-django-upgrade were broken when tests were removed, which is why they have not been updated , because the automated update system only works when fetching from pypi.

Using tarballs from github is more effort, which I will do because these are important packages and they are already in the openSUSE collection. Before adding new packages to openSUSE, and thus more work, I try to have the sdists on PyPI include tests, as I did in adamchainz/django-cors-headers#378 .

Copy link
Copy Markdown
Member

@carltongibson carltongibson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, I don't mind adding this. (🤷)

Thanks.

@carltongibson carltongibson changed the title Add tests and changelog to sdist Add changelog to sdist May 7, 2025
@carltongibson carltongibson merged commit 80d619d into django:main May 7, 2025
11 checks passed
@jayvdb jayvdb deleted the sdist branch May 7, 2025 23:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants