Fix parsing of "20161101" as YYYYMMDD instead of year 20161101#100
Open
dewey wants to merge 1 commit intobeetbox:masterfrom
Open
Fix parsing of "20161101" as YYYYMMDD instead of year 20161101#100dewey wants to merge 1 commit intobeetbox:masterfrom
dewey wants to merge 1 commit intobeetbox:masterfrom
Conversation
|
Thank you for the PR! The changelog has not been updated, so here is a friendly reminder to check if you need to add an entry. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #100 +/- ##
==========================================
+ Coverage 93.26% 93.28% +0.01%
==========================================
Files 16 16
Lines 817 819 +2
Branches 118 119 +1
==========================================
+ Hits 762 764 +2
Misses 35 35
Partials 20 20
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've noticed that some entries in my libraries had year > 9999 set and tracked it down to this being parsed wrongly by this function. I think this simple change will prevent this going forward. I added some tests to verify that and it looks good.
What do you think?