Skip to content

fix: migrate JS library icons to use internal CDN instead of third-pa…#41736

Open
Gurjit-30 wants to merge 2 commits intoappsmithorg:releasefrom
Gurjit-30:release
Open

fix: migrate JS library icons to use internal CDN instead of third-pa…#41736
Gurjit-30 wants to merge 2 commits intoappsmithorg:releasefrom
Gurjit-30:release

Conversation

@Gurjit-30
Copy link
Copy Markdown

@Gurjit-30 Gurjit-30 commented Apr 12, 2026

Description

Migrates JS library icons from third-party GitHub URLs to internal CDN to improve performance, privacy, and reliability.

Changes

  • Downloaded 14 GitHub avatar images for JS library authors
  • Updated recommendedLibraries.ts to use internal /icons/ paths
  • Added icons to app/client/public/icons/ directory

Benefits

  • Removes dependency on external GitHub avatar service
  • Improves loading performance (no external requests)
  • Enhances privacy (no external tracking)
  • Increases reliability (no external service downtime)

Fixes #35560

Summary by CodeRabbit

  • Chores
    • Optimized icon loading for recommended libraries by serving icons from local assets instead of external sources, improving performance and reliability.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Apr 12, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: b10766ea-aa3d-46d0-bdfe-b7156fe960f3

📥 Commits

Reviewing files that changed from the base of the PR and between 5743047 and 439a823.

⛔ Files ignored due to path filters (14)
  • app/client/public/icons/LiosK.png is excluded by !**/*.png
  • app/client/public/icons/MrRio.png is excluded by !**/*.png
  • app/client/public/icons/NaturalIntelligence.png is excluded by !**/*.png
  • app/client/public/icons/amplitude.png is excluded by !**/*.png
  • app/client/public/icons/appwrite.png is excluded by !**/*.png
  • app/client/public/icons/auth0.png is excluded by !**/*.png
  • app/client/public/icons/dchester.png is excluded by !**/*.png
  • app/client/public/icons/dcodeIO.png is excluded by !**/*.png
  • app/client/public/icons/getsentry.png is excluded by !**/*.png
  • app/client/public/icons/greggman.png is excluded by !**/*.png
  • app/client/public/icons/i18next.png is excluded by !**/*.png
  • app/client/public/icons/mholt.png is excluded by !**/*.png
  • app/client/public/icons/sindresorhus.png is excluded by !**/*.png
  • app/client/public/icons/supabase.png is excluded by !**/*.png
📒 Files selected for processing (1)
  • app/client/src/pages/Editor/Explorer/Libraries/recommendedLibraries.ts

Walkthrough

Migrated JavaScript library icons from external third-party URLs (GitHub, JSDelivr) to internally hosted assets in the /icons/ directory. All icon field values in the recommended libraries configuration were updated while preserving other entry data and application behavior.

Changes

Cohort / File(s) Summary
Icon URL Migration
app/client/src/pages/Editor/Explorer/Libraries/recommendedLibraries.ts
Updated 14 icon field references from external URLs (e.g., https://github.com/auth0.png?s=20) to local asset paths (e.g., /icons/auth0.png).

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

📦 Icons once wandered the web so far,
Now nestled at home beneath /icons/*,
Reliable, swift, and under our star,
No external outages dimming our tricks!
🚀✨

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed Title clearly summarizes the main change: migrating JS library icons from third-party URLs to internal CDN.
Description check ✅ Passed Description includes motivation, changes made, benefits, and references issue #35560. Covers required template sections adequately.
Linked Issues check ✅ Passed PR implements all requirements from #35560: icons migrated to internal CDN, library configurations updated, and dependencies eliminated.
Out of Scope Changes check ✅ Passed Changes are limited to icon path updates in recommendedLibraries.ts and addition of icon assets; no unrelated modifications.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Improvement]: Migrate JS Library Icons to Use Internal CDN Instead of Third-Party URLs

1 participant