fix(AsyncSelect): call fireOnChange() only when past actually updates… by JCelento · Pull Request #39298 · apache/superset

JCelento · 2026-04-11T20:39:23Z

SUMMARY

AsyncSelect paste: onChange is only fired when paste actually changes the value. In single mode, pasting a value equal to the current selection no longer triggers onChange. In multiple mode, building the next value from selectValueRef avoids stale closures; pasting only tokens that are already selected does not update state or call onChange. Unit tests cover paste, deduplication, and the no-op onChange case for multiple modes.
Alerts / reports (AlertReportModal): The Chart field uses allowClear so the selection can be cleared from the UI. getChartVisualizationType returns early when the chart value is missing or invalid so /api/v1/chart/:id is not called with bad input after clear. Adds a test that clearing the chart drives the expected empty state.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

BEFORE

AFTER

TESTING INSTRUCTIONS

Unit tests:
cd superset-frontend && npm run test -- packages/superset-ui-core/src/components/Select/AsyncSelect.test.tsx
npm run test -- src/features/alerts/AlertReportModal.test.tsx (or full suite as you prefer).
Manual :

Go to Alerts & Reports
Click + Alert and navigate to Alert Contents
Select Charts
Paste any text into the chart selection field
Expected results:
The pasted text should be used to search and filter the list of available charts, the same way typing works.

ADDITIONAL INFORMATION

Has associated issue:
Required feature flags:
Changes UI
Includes DB Migration (follow approval process in SIP-59)
- Migration is atomic, supports rollback & is backwards-compatible
- Confirm DB migration upgrade and downgrade tested
- Runtime estimates and downtime expectations provided
Introduces new feature or API
Removes existing feature or API

superset-frontend/packages/superset-ui-core/src/components/Select/AsyncSelect.tsx

codecov · 2026-04-11T20:56:41Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 64.42%. Comparing base (c971ea3) to head (57eae54).

❌ Your project check has failed because the head coverage (99.81%) is below the target coverage (100.00%). You can increase the head coverage or adjust the target coverage.

Additional details and impacted files

@@           Coverage Diff           @@
##           master   #39298   +/-   ##
=======================================
  Coverage   64.41%   64.42%           
=======================================
  Files        2554     2554           
  Lines      132660   132667    +7     
  Branches    30778    30780    +2     
=======================================
+ Hits        85459    85466    +7     
  Misses      45715    45715           
  Partials     1486     1486

Flag	Coverage Δ
javascript	`66.11% <100.00%> (+<0.01%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

bito-code-review · 2026-04-13T13:34:41Z

Code Review Agent Run #42db95

Actionable Suggestions - 0

Review Details

Files reviewed - 4 · Commit Range: 4dc7413..08629eb
- superset-frontend/packages/superset-ui-core/src/components/Select/AsyncSelect.test.tsx
- superset-frontend/packages/superset-ui-core/src/components/Select/AsyncSelect.tsx
- superset-frontend/src/features/alerts/AlertReportModal.test.tsx
- superset-frontend/src/features/alerts/AlertReportModal.tsx
Files skipped - 0
Tools
- Whispers (Secret Scanner) - ✔︎ Successful
- Detect-secrets (Secret Scanner) - ✔︎ Successful

Bito Usage Guide

Commands

Type the following command in the pull request comment and save the comment.

/review - Manually triggers a full AI review.
/pause - Pauses automatic reviews on this pull request.
/resume - Resumes automatic reviews.
/resolve - Marks all Bito-posted review comments as resolved.
/abort - Cancels all in-progress reviews.

Refer to the documentation for additional commands.

Configuration

This repository uses Superset You can customize the agent settings here or contact your Bito workspace admin at evan@preset.io.

Documentation & Help

AI Code Review powered by

superset-frontend/packages/superset-ui-core/src/components/Select/AsyncSelect.tsx

bito-code-review · 2026-04-13T14:56:48Z

Code Review Agent Run #d53417

Actionable Suggestions - 0

Review Details

Files reviewed - 2 · Commit Range: 08629eb..52e3b57
- superset-frontend/packages/superset-ui-core/src/components/Select/AsyncSelect.test.tsx
- superset-frontend/src/features/alerts/AlertReportModal.test.tsx
Files skipped - 0
Tools
- Whispers (Secret Scanner) - ✔︎ Successful
- Detect-secrets (Secret Scanner) - ✔︎ Successful

Bito Usage Guide

Commands

Type the following command in the pull request comment and save the comment.

/review - Manually triggers a full AI review.
/pause - Pauses automatic reviews on this pull request.
/resume - Resumes automatic reviews.
/resolve - Marks all Bito-posted review comments as resolved.
/abort - Cancels all in-progress reviews.

Refer to the documentation for additional commands.

Configuration

This repository uses Superset You can customize the agent settings here or contact your Bito workspace admin at evan@preset.io.

Documentation & Help

AI Code Review powered by

… the value

…s/Select/AsyncSelect.tsx Co-authored-by: codeant-ai-for-open-source[bot] <244253245+codeant-ai-for-open-source[bot]@users.noreply.github.com>

…AlertReportModal

bito-code-review · 2026-04-13T18:18:33Z

Code Review Agent Run #adf21d

Actionable Suggestions - 0

Review Details

Files reviewed - 4 · Commit Range: 0a0f8f5..fd8f980
- superset-frontend/packages/superset-ui-core/src/components/Select/AsyncSelect.test.tsx
- superset-frontend/packages/superset-ui-core/src/components/Select/AsyncSelect.tsx
- superset-frontend/src/features/alerts/AlertReportModal.test.tsx
- superset-frontend/src/features/alerts/AlertReportModal.tsx
Files skipped - 0
Tools
- Whispers (Secret Scanner) - ✔︎ Successful
- Detect-secrets (Secret Scanner) - ✔︎ Successful

Bito Usage Guide

Commands

Type the following command in the pull request comment and save the comment.

/review - Manually triggers a full AI review.
/pause - Pauses automatic reviews on this pull request.
/resume - Resumes automatic reviews.
/resolve - Marks all Bito-posted review comments as resolved.
/abort - Cancels all in-progress reviews.

Refer to the documentation for additional commands.

Configuration

This repository uses Superset You can customize the agent settings here or contact your Bito workspace admin at evan@preset.io.

Documentation & Help

AI Code Review powered by

pull-request-size bot added the size/M label Apr 11, 2026

JCelento marked this pull request as draft April 11, 2026 20:39

github-actions bot added the packages label Apr 11, 2026

dosubot bot added the change:frontend Requires changing the frontend label Apr 11, 2026

codeant-ai-for-open-source bot reviewed Apr 11, 2026

View reviewed changes

superset-frontend/packages/superset-ui-core/src/components/Select/AsyncSelect.tsx Outdated Show resolved Hide resolved

JCelento marked this pull request as ready for review April 13, 2026 13:00

dosubot bot added the alert-reports Namespace | Anything related to the Alert & Reports feature label Apr 13, 2026

pull-request-size bot added size/L and removed size/M labels Apr 13, 2026

codeant-ai-for-open-source bot reviewed Apr 13, 2026

View reviewed changes

superset-frontend/packages/superset-ui-core/src/components/Select/AsyncSelect.tsx Outdated Show resolved Hide resolved

JCelento force-pushed the fix/search-copy-paste branch from 52e3b57 to 6d97c75 Compare April 13, 2026 17:16

JCelento and others added 6 commits April 13, 2026 14:56

fix(AsyncSelect): call fireOnChange() only when past actually updates…

0a0f8f5

… the value

fix: update superset-frontend/packages/superset-ui-core/src/component…

b65aa48

…s/Select/AsyncSelect.tsx Co-authored-by: codeant-ai-for-open-source[bot] <244253245+codeant-ai-for-open-source[bot]@users.noreply.github.com>

test: adds missing tests to cover current changes on AsyncSelect and …

eb2eb1e

…AlertReportModal

fix: remove redundant fireOnChange()

ca392ab

test: improve test descriptions and naming

2536921

fix: use selectValueRef.current to avoid race condition

fd8f980

JCelento force-pushed the fix/search-copy-paste branch from 7196f5b to fd8f980 Compare April 13, 2026 17:56

ci-cd: triggers ci again

57eae54

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(AsyncSelect): call fireOnChange() only when past actually updates…#39298

fix(AsyncSelect): call fireOnChange() only when past actually updates…#39298
JCelento wants to merge 7 commits intoapache:masterfrom
JCelento:fix/search-copy-paste

JCelento commented Apr 11, 2026 •

edited

Loading

Uh oh!

Uh oh!

codecov bot commented Apr 11, 2026 •

edited

Loading

Uh oh!

bito-code-review bot commented Apr 13, 2026 •

edited

Loading

Code Review Agent Run #42db95

Uh oh!

Uh oh!

bito-code-review bot commented Apr 13, 2026 •

edited

Loading

Code Review Agent Run #d53417

Uh oh!

bito-code-review bot commented Apr 13, 2026 •

edited

Loading

Code Review Agent Run #adf21d

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Conversation

JCelento commented Apr 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

SUMMARY

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

BEFORE

AFTER

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

Uh oh!

Uh oh!

codecov bot commented Apr 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

bito-code-review bot commented Apr 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Code Review Agent Run #42db95

Uh oh!

Uh oh!

bito-code-review bot commented Apr 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Code Review Agent Run #d53417

Uh oh!

bito-code-review bot commented Apr 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Code Review Agent Run #adf21d

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

JCelento commented Apr 11, 2026 •

edited

Loading

codecov bot commented Apr 11, 2026 •

edited

Loading

bito-code-review bot commented Apr 13, 2026 •

edited

Loading

bito-code-review bot commented Apr 13, 2026 •

edited

Loading

bito-code-review bot commented Apr 13, 2026 •

edited

Loading