cloudidentity: Add dynamic group support to google_cloud_identity_group#17107
Open
keeleysam wants to merge 1 commit intoGoogleCloudPlatform:mainfrom
Open
cloudidentity: Add dynamic group support to google_cloud_identity_group#17107keeleysam wants to merge 1 commit intoGoogleCloudPlatform:mainfrom
keeleysam wants to merge 1 commit intoGoogleCloudPlatform:mainfrom
Conversation
Adds dynamicGroupMetadata as an optional nested object on the Cloud Identity Group resource, enabling CEL query-based dynamic membership. This brings parity with the forked googleworkspace provider's group_dynamic resource so it can be retired. The update mask uses dynamicGroupMetadata.queries to match the API's expected field path. Includes a documentation example and acceptance tests for create, import, and update flows.
modular-magician
added
the
awaiting-approval
|
Googlers: For automatic test runs see go/terraform-auto-test-runs. @melinath, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look. You can help make sure that review is quick by doing a self-review and by running impacted tests locally. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
dynamic_group_metadatablock togoogle_cloud_identity_group, enabling CEL query-based automatic membership (e.g.,user.organizations.exists(org, org.department=='Engineering'))update_mask_fieldsto senddynamicGroupMetadata.querieson updates, matching the Cloud Identity API's expected field pathMotivation
This replaces the need for community forked
terraform-provider-googleworkspaceto manage dynamic groups. Since the Cloud Identity API already supportsdynamicGroupMetadataon the samegroups/{group_id}endpoint, extending the existing resource is the correct approach rather than creating a separate resource.Release Note Template for Downstream PRs (will be copied)
See Write release notes for guidance.