Open
Conversation
incogiscool
reviewed
Apr 7, 2026
| def transmit_hex(conn: Serial, hex_payload: str) -> bool: | ||
| radio_write(conn, "mac pause") | ||
| line = str(conn.readline()) | ||
| if "4294967245" not in line: |
Contributor
There was a problem hiding this comment.
Just a question - what does this number mean and why do we fail the transmission if its not in the serial?
Contributor
Author
There was a problem hiding this comment.
To be completely honest I just copied the function that transmits non-hex data. That number is probably the response you expect after sending mac pause.
what do you mean by "fail transmission if its not in the serial"?
Contributor
There was a problem hiding this comment.
Thats valid haha
In that if statement your returning false if that number isnt in the line
incogiscool
approved these changes
Apr 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As title
The transmission script can now encode a csv file into blocks and transmit it