CI: implement best practices and update actions#100
Merged
black-sliver merged 4 commits intoArchipelagoMW:mainfrom Apr 15, 2026
Merged
CI: implement best practices and update actions#100black-sliver merged 4 commits intoArchipelagoMW:mainfrom
black-sliver merged 4 commits intoArchipelagoMW:mainfrom
Conversation
if supported; 3 days is hopefully good enough to catch bad stuff. Actions currently do not support cooldown, but hopefully this will be added in the future.
actions/* are pinned to version. Those should use immutable actions preview. gradle/* is pinned by commit hash.
cjmang
approved these changes
Apr 15, 2026
| cache: gradle | ||
| - name: Submit Dependency Snapshot | ||
| uses: gradle/actions/dependency-submission@v4 | ||
| uses: gradle/actions/dependency-submission@50e97c2cd7a37755bbfafc9c5b7cafaece252f6e # v6.1.0 |
Collaborator
There was a problem hiding this comment.
By my reading, this looks to have been superceded twice. Firstly, in favor of https://github.com/gradle/gradle-build-action?tab=readme-ov-file#github-dependency-graph-support, and then that was replaced in favor of https://github.com/gradle/actions/blob/main/docs/setup-gradle.md.
Dunno that we need to change it right away, but eventually I guess.
Member
Author
There was a problem hiding this comment.
I think setup-gradle replaces setup-java (and also implements submitting the dependency graph), but gradle/actions/dependency-submission seems to still be maintained.
We could switch in the future, but I am not sure if setup-gradle has any real advantage over what we are doing now.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
permissions:everywhere with the minimal set of actually required permissions:actions/*still use the discontinued preview of immutable actions. If immutable actions ever get completely removed, I hopeactions/*will move to immutable releases (to make tags immutable)gradle/*is third party, so we pin by hashWe should probably make the maven signing/publish conditional at some point so forks can build in CI.