Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a24bb60a27
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| isSubdigestLeaf(topology) || | ||
| isAnyAddressSubdigestLeaf(topology) || | ||
| isNodeLeaf(topology) | ||
| ) { | ||
| return [{ weight: 0n, topology }] |
There was a problem hiding this comment.
minimiseSignedTopology currently buckets subdigest and any-address-subdigest leaves with unsigned signer leaves as weight: 0n, but in recoverTopology those leaves can contribute effectively unlimited weight when the digest matches the config-update payload. In update flows that call this minimizer after recovery (e.g., state/sequence), this causes the algorithm to keep extra signer signatures even when zero signer signatures are needed, so the returned topology is not actually minimal and can inflate encoded signature size/gas.
Useful? React with 👍 / 👎.
1 participant
No description provided.