Poco::Net::FTPClientSession constructor can throw

[micheleselea]

In Poco::Net::FTPClientSession 2 of the 3 constructors can throw

	_pControlSocket->setReceiveTimeout(_timeout); <--here
	if (readWelcomeMessage)
	{
		receiveServerReadyReply(); <---here
	}
	else
	{
		_serverReady = true;
	}

	_pControlSocket->setReceiveTimeout(_timeout);<--here
	if (!username.empty())
		login(username, password); <--here

If the constructor throw the destructor is never called so we can have some memory leak because close() is never called

it's enough, for example, to create a socket on an http/https connection and pass it to the constructor: the receiveServerReadyReply will throw

[micheleselea]

Because the most likely exception is thrown by
receiveServerReadyReply();
and
login(username, password);
as a walkaround for now we can pass "readWelcomeMessage=false" to the constructor and do a receiveServerReadyReply() after: unfortunately, you cannot call the function directly because is private

or pass empty username and do a login(username, password); after